Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade @ampproject/toolbox-optimizer to 2.6.0 #16043

Merged
merged 3 commits into from
Aug 10, 2020
Merged

upgrade @ampproject/toolbox-optimizer to 2.6.0 #16043

merged 3 commits into from
Aug 10, 2020

Conversation

sebastianbenz
Copy link
Contributor

See release notes.

Highlight: hero images can now be server-side rendered by annotating then with data-hero. This will greatly improves LCP when using large images in the first viewport.

<amp-img data-hero src="/hero.jpg" layout="responsive" width="640" height="480"></amp-img>

Also fixes #15979

Timer
Timer previously approved these changes Aug 10, 2020
View reviewed changes
ijjk
ijjk previously approved these changes Aug 10, 2020
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Aug 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
buildDuration 12s 12.6s ⚠️ +588ms
nodeModulesSize 65.8 MB 58.3 MB -7.48 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.294 2.375 ⚠️ +0.08
/ avg req/sec 1089.83 1052.58 ⚠️ -37.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.382 1.447 ⚠️ +0.07
/error-in-render avg req/sec 1808.44 1727.68 ⚠️ -80.76
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8927408..22b2.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-15cde23..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
index.html gzip 948 B 948 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.85 kB 2.85 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
buildDuration 13.8s 13.9s ⚠️ +67ms
nodeModulesSize 65.8 MB 58.3 MB -7.48 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8927408..22b2.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-15cde23..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 7e31100

@Timer Timer dismissed stale reviews from ijjk and themself via 90075d5 August 10, 2020 15:43
@ijjk
Copy link
Member

ijjk commented Aug 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
buildDuration 10.8s 11s ⚠️ +244ms
nodeModulesSize 64.7 MB 57.2 MB -7.48 MB
Page Load Tests Overall increase ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.105 2.026 -0.08
/ avg req/sec 1187.7 1233.93 +46.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.307 1.318 ⚠️ +0.01
/error-in-render avg req/sec 1913.15 1896.16 ⚠️ -16.99
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8927408..22b2.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-15cde23..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
index.html gzip 948 B 948 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.85 kB 2.85 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
buildDuration 12.5s 12.5s ⚠️ +26ms
nodeModulesSize 64.7 MB 57.2 MB -7.48 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..ec1a.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-8927408..22b2.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-15cde23..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.6 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 90075d5

@kodiakhq kodiakhq bot merged commit d6ad0d0 into vercel:canary Aug 10, 2020
This was referenced Jun 26, 2021
Open
Open
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk ijjk left review comments

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styles not getting passed to Amp Toolbox after Next update to 9.5
3 participants
@sebastianbenz @ijjk @Timer